Re: [aur-general] Wrote Small AUR Helper

On Fri, Jan 14, 2011 at 12:36 AM, Nathan Owens wrote:

On 01/13/2011 10:13 PM, Nathan Owens wrote:

...

On 01/13/2011 08:41 PM, Jonathan Conder wrote:

...

On 14 January 2011 15:57, Nathan Owens  wrote:

...

I wrote a little AUR helper in C++, though currently it only downloads the tarball if the package name is valid. I am new to C++ and wanted to know if you thought the code was good. I was thinking about putting it in AUR, but figured I would asked for opinion first. Here is the url for the code: http://pastebin.com/aSW1awD4

So far so good, just a few pointers:

- The struct Aur isn't necessary - the file field is never used. You should remove Aur:: from the getFile definition to make it an ordinary function. - The return type of getFile should be void, not char. I would suggest passing the -Wall and -pedantic options to g++ so the compiler would catch these types of issues. - The only headers I think you need are<iostream>,  and<string> (not, which is a C header). I might have missed something though. - As a next step I would use a library to download the file, rather than calling wget which isn't very efficient. You might choose libcurl, libfetch, libsoup, Qt, or maybe something else. - Although it isn't needed yet, I would suggest adding a break statement after case 1, to avoid errors when you add more cases.

Hope this helps, Jonathan

Refresh to code. I updated after I noticed the AUR:: stuff wasnt needed. So I changed the struct to class

Also just remembered, there was a discussion about having a AUR helper in community, but since others actually installed it for the user they wouldn't be added to community. What I thought about, maybe after it gets improved and enough votes, I wonder if it might be able to be added to community.

Sorry but aur helpers aren't allowed in [community], and that really is a hard rule.