Hi, thanks for your comments.
Lone_Wolf wrote:
timidity++ and fluidsynth are the 2 most common software midi
synthesizers on archlinux.
I suggest you list them as optdepends .
Thanks, I did that (and also checked that it works with both of these).
Polarian wrote:
Appreciate it if you paste the PKGBUILD into the email body, and not
attach it. Would also make it easier to quote.
Here is the updated PKGBUILD:
--8<---------------cut here---------------start------------->8---
# Maintainer: Jonas Serych
pkgname='powertabeditor'
pkgver='2.0.0_alpha19'
pkgrel=1
pkgdesc="Guitar tablature viewer and editor"
arch=('x86_64')
url="https://powertab.github.io/"
license=('GPL-3.0-only')
depends=('boost-libs' 'boost' 'doctest' 'minizip' 'pugixml' 'rtmidi' 'alsa-lib' 'nlohmann-json' 'qt5-base' 'qt5-tools')
optdepends=('timidity++: MIDI playback support'
'fluidsynth: MIDI playback support')
makedepends=('cmake')
source=("https://github.com/powertab/${pkgname}/archive/refs/tags/${pkgver//_/-}.tar.gz")
sha256sums=('318e14370bd60670dadfe70d2f124d817d51017ec13011f577080633d83f41d4')
build() {
cmake -B build -S "${pkgname}-${pkgver//_/-}" \
-DCMAKE_BUILD_TYPE='None' \
-DCMAKE_INSTALL_PREFIX=/usr
cmake --build build
}
check() {
ctest --test-dir build --output-on-failure
}
package() {
DESTDIR="$pkgdir" cmake --install build
}
--8<---------------cut here---------------end--------------->8---
Any other things to improve? Or can I put it to AUR?
Best,
Jonas Serych