Hello,
This is my first PKGBUILD. If someone has time, I would like to get some reviews from other archers.
https://gitlab.com/saruman9/pkgbuilds/tree/master/understand-bin
-- Alex
On Mon, 13 Jun 2016 14:14:00 +0300 Alex Sarum via aur-general aur-general@archlinux.org wrote:
Hello,
This is my first PKGBUILD. If someone has time, I would like to get some reviews from other archers.
https://gitlab.com/saruman9/pkgbuilds/tree/master/understand-bin
-- Alex
What's with the "scitools" variable? Doesn't seem to do anything useful.
source and checksum arrays support architecture specific arrays now. Check the man page/wiki page.
You shouldn't be changing anything in $srcdir in the package function. What happens when someone runs makepkg --repackage?
There's really no reason to change the name of the license file.
"install -d "$pkgdir/usr/bin"" doesn't really do anything since you're using the -D option on the next line. That will create the dir.
You should be consistent with how you use variables. Sometimes you have them in braces and sometimes you don't, even in the same path.
What's with the "scitools" variable? Doesn't seem to do anything useful.
Deleted.
source and checksum arrays support architecture specific arrays now. Check the man page/wiki page.
I known about it, but I think that it will be shorter.
You shouldn't be changing anything in $srcdir in the package function. What happens when someone runs makepkg --repackage?
Corrected.
There's really no reason to change the name of the license file.
Corrected.
"install -d "$pkgdir/usr/bin"" doesn't really do anything since you're using the -D option on the next line. That will create the dir.
Corrected.
You should be consistent with how you use variables. Sometimes you have them in braces and sometimes you don't, even in the same path.
Corrected.
I can share my PKGBUILD now?
P.S. I have not received a reply. I waited digest and copied ID message to In-Reply-To. I hope this will works. So it should be? And sorry for my EnGlIsH.
You can specify a general source array as well as architecture specific ones, it adds them together. So you should put desktop and the /usr/bin binary file in there instead of repeating it.
Otherwise it looks good to me now.
Regards, Justin
aur-general@lists.archlinux.org