On 17-03-2019 10:29, Martin Wilson wrote:

I've put together a package for upload to the AUR, but since it's my first, I would like to know if there are any problems with it:

https://github.com/martin3141/tarquin_arch

cheers,

Martin

The source url points to your github repo instead of official tarquin download locations at sourceforge. The latest version at https://sourceforge.net/projects/tarquin/files/ is 4.3.11 , where does your 4.3.12 file come from ? LW

On 3/17/19 5:29 AM, Martin Wilson wrote:

I've put together a package for upload to the AUR, but since it's my first, I would like to know if there are any problems with it:

https://github.com/martin3141/tarquin_arch

cheers,

Martin

Hello Martin. Here are my notes. Please note that this is my first review, so I would wait to hear from some of the more experienced community members to let you know if I get anything wrong. Quote all variables. Prepend $pkgname-$pkgver.tar.gz:: to source to rename the source tarball: "$pkgname-$pkgver.tar.gz::https://github.com/martin3141/tarquin/archive/v$pkgver.tar.gz" Add CMakeListsPatch.txt to source array. Don't forget to update the checksums after adding patch to source array. Change patch line in prepare() function from relative path to "$srcdir"/CMakeListsPatch.txt Also in the prepare() function, I would rather see proto.sh incorporated in the PKGBUILD directly. It is only 3 lines. The package() function can be shortened to one install line: install -Dm755 "$srcdir/$pkgname-$pkgver/src/build/redist/"tarquin{,gui} -t "$pkgdir"/usr/bin Add a .gitignore to the repository. I prefer to exclude everything and explicitly add what is needed. Others prefer to explicitly exclude instead. My default .gitignore for AUR looks like this: * !PKGBUILD !.SRCINFO !.gitignore To that you would need to add !CMakeListsPatch.txt for this package. I hope this is helpful. Paul

I am Sam don't know how we found each other, but bless you all and I guess u can delete me if there's no harm caused by doing so...thank you and always keep praying God bless u all. On Mon, Mar 18, 2019, 3:01 PM Martin Wilson wrote:

Yes that helps, thanks Paul.

On Sun, 17 Mar 2019 at 23:07, Paul Hentschel wrote:

...

On 3/17/19 5:29 AM, Martin Wilson wrote:

...

I've put together a package for upload to the AUR, but since it's my first, I would like to know if there are any problems with it:

https://github.com/martin3141/tarquin_arch

cheers,

Martin

Hello Martin. Here are my notes. Please note that this is my first review, so I would wait to hear from some of the more experienced community members to let you know if I get anything wrong.

Quote all variables.

Prepend $pkgname-$pkgver.tar.gz:: to source to rename the source tarball: "$pkgname-$pkgver.tar.gz:: https://github.com/martin3141/tarquin/archive/v$pkgver.tar.gz" Add CMakeListsPatch.txt to source array. Don't forget to update the checksums after adding patch to source array.

Change patch line in prepare() function from relative path to "$srcdir"/CMakeListsPatch.txt Also in the prepare() function, I would rather see proto.sh incorporated in the PKGBUILD directly. It is only 3 lines.

The package() function can be shortened to one install line: install -Dm755 "$srcdir/$pkgname-$pkgver/src/build/redist/"tarquin{,gui} -t "$pkgdir"/usr/bin

Add a .gitignore to the repository. I prefer to exclude everything and explicitly add what is needed. Others prefer to explicitly exclude instead. My default .gitignore for AUR looks like this: * !PKGBUILD !.SRCINFO !.gitignore

To that you would need to add !CMakeListsPatch.txt for this package.

I hope this is helpful. Paul

On Mon, Mar 18, 2019, 3:01 PM Martin Wilson wrote:

Yes that helps, thanks Paul.

On Sun, 17 Mar 2019 at 23:07, Paul Hentschel wrote:

...

On 3/17/19 5:29 AM, Martin Wilson wrote:

...

I've put together a package for upload to the AUR, but since it's my first, I would like to know if there are any problems with it:

https://github.com/martin3141/tarquin_arch

cheers,

Martin

Hello Martin. Here are my notes. Please note that this is my first review, so I would wait to hear from some of the more experienced community members to let you know if I get anything wrong.

Quote all variables.

Prepend $pkgname-$pkgver.tar.gz:: to source to rename the source tarball: "$pkgname-$pkgver.tar.gz:: https://github.com/martin3141/tarquin/archive/v$pkgver.tar.gz" Add CMakeListsPatch.txt to source array. Don't forget to update the checksums after adding patch to source array.

Change patch line in prepare() function from relative path to "$srcdir"/CMakeListsPatch.txt Also in the prepare() function, I would rather see proto.sh incorporated in the PKGBUILD directly. It is only 3 lines.

The package() function can be shortened to one install line: install -Dm755 "$srcdir/$pkgname-$pkgver/src/build/redist/"tarquin{,gui} -t "$pkgdir"/usr/bin

Add a .gitignore to the repository. I prefer to exclude everything and explicitly add what is needed. Others prefer to explicitly exclude instead. My default .gitignore for AUR looks like this: * !PKGBUILD !.SRCINFO !.gitignore

To that you would need to add !CMakeListsPatch.txt for this package.

I hope this is helpful. Paul

On Mon, Mar 18, 2019, 3:01 PM Martin Wilson wrote:

Yes that helps, thanks Paul.

On Sun, 17 Mar 2019 at 23:07, Paul Hentschel wrote:

...

On 3/17/19 5:29 AM, Martin Wilson wrote:

...

I've put together a package for upload to the AUR, but since it's my first, I would like to know if there are any problems with it:

https://github.com/martin3141/tarquin_arch

cheers,

Martin

Hello Martin. Here are my notes. Please note that this is my first review, so I would wait to hear from some of the more experienced community members to let you know if I get anything wrong.

Quote all variables.

Prepend $pkgname-$pkgver.tar.gz:: to source to rename the source tarball: "$pkgname-$pkgver.tar.gz:: https://github.com/martin3141/tarquin/archive/v$pkgver.tar.gz" Add CMakeListsPatch.txt to source array. Don't forget to update the checksums after adding patch to source array.

Change patch line in prepare() function from relative path to "$srcdir"/CMakeListsPatch.txt Also in the prepare() function, I would rather see proto.sh incorporated in the PKGBUILD directly. It is only 3 lines.

The package() function can be shortened to one install line: install -Dm755 "$srcdir/$pkgname-$pkgver/src/build/redist/"tarquin{,gui} -t "$pkgdir"/usr/bin

Add a .gitignore to the repository. I prefer to exclude everything and explicitly add what is needed. Others prefer to explicitly exclude instead. My default .gitignore for AUR looks like this: * !PKGBUILD !.SRCINFO !.gitignore

To that you would need to add !CMakeListsPatch.txt for this package.

I hope this is helpful. Paul

Thanks Le 20/03/2019 à 08:49, marnout a écrit :

Hellow everyone, My brother-dcpj140w package in aur is invaded by spam. Is there a nicce TU to get rid of them. My package is at : https://aur.archlinux.org/packages/brother-dcpj140w/ and the list of spammers is : TannaLDietrich peterprism ramsonroni wowcomputertech wowcomputertech hpprintercare hpprintercare Geeksquad93 Georgeson johnwalkr

Thank you very much, and sorry for my approximative english.

Mourad Arnout 25 rue de la Vieille Pierre 79800 Exoudun http://arad.free.fr https://github.com/marnout

P.S. I have a lot of free time and i can participate by doing certain tasks for the community. For instance I can clean up in aur under the guidance of a TU.