[aur-general] PKGBUILD for zetacoin-qt-git

older
[aur-general] Signoff report for...

Bruno Jimenez

31 Oct 2013 31 Oct '13

3:27 p.m.

Hi, I have been interested lately in alt-currency and I wanted to try zetacoin, but I couldn't find a package in the repos or the AUR. So, using terracoin-qt's PKGBUILD (which is outdated, by the way) I have created the PKGBUILD for zetacoin-qt-git. As it is the first PKGBUILD I make, I wanted to make sure that it is well written. Thanks in Advance! Bruno P.S: Maybe tomorrow, I'll make also the zetacoin-daemon-git PKGBUILD in case you want to advice me on something

Show replies by date

Jeremy Audet

1 Nov 1 Nov

12:33 a.m.

Where is the PKGBUILD file? Can you provide a link? I think the mailing list strips attachments off emails. If so, your best bet is to use a service like pastebin or gist. --Jeremy "Ichimonji10" Audet On Thu, Oct 31, 2013 at 11:27 AM, Bruno Jimenez wrote:

...

Hi,

I have been interested lately in alt-currency and I wanted to try zetacoin, but I couldn't find a package in the repos or the AUR.

So, using terracoin-qt's PKGBUILD (which is outdated, by the way) I have created the PKGBUILD for zetacoin-qt-git.

As it is the first PKGBUILD I make, I wanted to make sure that it is well written.

Thanks in Advance! Bruno

P.S: Maybe tomorrow, I'll make also the zetacoin-daemon-git PKGBUILD in case you want to advice me on something

Bruno Jimenez

8:51 a.m.

Oh, I's so sorry, I didn't know that the list removed attachments from emails. Here's the PKGBUILD: http://pastebin.com/gVP8UeJq Thanks in advance! Bruno On Thu, 2013-10-31 at 20:33 -0400, Jeremy Audet wrote:

...

Where is the PKGBUILD file? Can you provide a link?

I think the mailing list strips attachments off emails. If so, your best bet is to use a service like pastebin or gist.

--Jeremy "Ichimonji10" Audet

On Thu, Oct 31, 2013 at 11:27 AM, Bruno Jimenez wrote:

...
Hi,

I have been interested lately in alt-currency and I wanted to try zetacoin, but I couldn't find a package in the repos or the AUR.

So, using terracoin-qt's PKGBUILD (which is outdated, by the way) I have created the PKGBUILD for zetacoin-qt-git.

As it is the first PKGBUILD I make, I wanted to make sure that it is well written.

Thanks in Advance! Bruno

P.S: Maybe tomorrow, I'll make also the zetacoin-daemon-git PKGBUILD in case you want to advice me on something

Jeremy Audet

8:18 p.m.

Some improvements: 1. Add zetacoin-qt.desktop to the `source` and `sha256sums` arrays. 2. Add a function named `pkgver` to the PKGBUILD file. [1] This function will allow `makepkg` to update the version number automatically, relieving you of the need to update the version number by hand. 3. The comment at the top of the package should say "Based on terracoin-qt PKGBUILD", not "Based in terracoin-qt PKGBUILD". 4. Consider explicitly `cd`-ing into the `$srcdir` directory. Though this step is not strictly necessary, it makes your intent more clear to others reading through the PKGBUILD. As a Python programmer would say, "Explicit is better than implicit." 5. Consider removing the "miniupnpc" dependency from the package. `namcap` warns that it is not necessary. Do not remote the dependency blindly, though: namcap is sometimes wrong about dependencies. I am not knowledgeable about GUI applications, so I cannot comment on the .desktop or .install files. [1] https://wiki.archlinux.org/index.php/VCS_PKGBUILD_Guidelines#The_pkgver.28.2... On Fri, Nov 1, 2013 at 4:51 AM, Bruno Jimenez wrote:

...

Oh, I's so sorry, I didn't know that the list removed attachments from emails.

Here's the PKGBUILD: http://pastebin.com/gVP8UeJq

Thanks in advance! Bruno

On Thu, 2013-10-31 at 20:33 -0400, Jeremy Audet wrote:

...
Where is the PKGBUILD file? Can you provide a link?

I think the mailing list strips attachments off emails. If so, your best bet is to use a service like pastebin or gist.

--Jeremy "Ichimonji10" Audet

On Thu, Oct 31, 2013 at 11:27 AM, Bruno Jimenez
...
Hi,

I have been interested lately in alt-currency and I wanted to try zetacoin, but I couldn't find a package in the repos or the AUR.

So, using terracoin-qt's PKGBUILD (which is outdated, by the way) I have created the PKGBUILD for zetacoin-qt-git.

As it is the first PKGBUILD I make, I wanted to make sure that it is well written.

Thanks in Advance! Bruno

P.S: Maybe tomorrow, I'll make also the zetacoin-daemon-git PKGBUILD in case you want to advice me on something

Bruno Jimenez

10:36 p.m.

Hi, Here's the new PKGBUILD: http://pastebin.com/fL2JUH3Q The zetacoin-qt.desktop and zetacoin-qt-git.install are the same as before. On Fri, 2013-11-01 at 16:18 -0400, Jeremy Audet wrote:

...

Some improvements:

1. Add zetacoin-qt.desktop to the `source` and `sha256sums` arrays.

They were already added, do you mean zetacoin-qt-git.install?

...

2. Add a function named `pkgver` to the PKGBUILD file. [1] This function will allow `makepkg` to update the version number automatically, relieving you of the need to update the version number by hand.

Added the same one that mesa-git uses, would it serve?

...

3. The comment at the top of the package should say "Based on terracoin-qt PKGBUILD", not "Based in terracoin-qt PKGBUILD".

Thanks for this, english isn't my mother language and I usually confuse prepositions as in this case.

...

4. Consider explicitly `cd`-ing into the `$srcdir` directory. Though this step is not strictly necessary, it makes your intent more clear to others reading through the PKGBUILD. As a Python programmer would say, "Explicit is better than implicit."

Here I'm afraid that I'm not following you. What do you mean with 'cd'-ing explicitly?

...

5. Consider removing the "miniupnpc" dependency from the package. `namcap` warns that it is not necessary. Do not remote the dependency blindly, though: namcap is sometimes wrong about dependencies.

I have removed the 'miniupnpc' dependency and recompiled it, it didn't complain. I have this package installed and it seems to work, so I think it may be safe to remove it.

...

I am not knowledgeable about GUI applications, so I cannot comment on the .desktop or .install files.

Neither I am, this is just an adaptation of the terracoin-qt PKGBUILD so it works with zetacoin-qt

...

[1] https://wiki.archlinux.org/index.php/VCS_PKGBUILD_Guidelines#The_pkgver.28.2...

Thanks in advance! Bruno

Jeremy Audet

2 Nov 2 Nov

3:12 p.m.

...

...
1. Add zetacoin-qt.desktop to the `source` and `sha256sums` arrays. They were already added, do you mean zetacoin-qt-git.install?

Whoops, I misread the PKGBUILD. Ignore my suggestion. No, you do not need to add zetacoin-qt-git.install to the `source` and `sha256sums` arrays.

...

...
2. Add a function named `pkgver` to the PKGBUILD file. [1] This function will allow `makepkg` to update the version number automatically, relieving you of the need to update the version number by hand. Added the same one that mesa-git uses, would it serve?

The `pkgver` you added is OK, but it could be better. The zetacoin git repository has tagged releases, and the wiki states: [1]

...

It is recommended to have following version format: *RELEASE.rREVISION*[...]

Here's a better command for generating a package version number:

...

git describe --long | sed -E 's/([^-]*-g)/r\1/;s/-/./g'

That command generates the following version number:

...

v0.8.2.r218.g5eed859

...

...
4. Consider explicitly `cd`-ing into the `$srcdir` directory. Though this step is not strictly necessary, it makes your intent more clear to others reading through the PKGBUILD. As a Python programmer would say, "Explicit is better than implicit." Here I'm afraid that I'm not following you. What do you mean with 'cd'-ing explicitly?

Consider adding `cd "$srcdir"` to the beginning of the `package()` function. Please excuse my use of bastardized english. I could have worded my suggestion more clearly.

...

...
5. Consider removing the "miniupnpc" dependency from the package. `namcap` warns that it is not necessary. Do not remote the dependency blindly, though: namcap is sometimes wrong about dependencies. I have removed the 'miniupnpc' dependency and recompiled it, it didn't complain. I have this package installed and it seems to work, so I think it may be safe to remove it.

The bitcoin docs discuss how to build bitcoin on unix. [2] (zetacoin is based on bitcoin, so the bitcoin docs should be relevant) They state:

...

miniupnpc may be used for UPnP port mapping. It can be downloaded from here. UPnP support is compiled in and turned off by default.

Also, namcap complains about the zetacoin-qt-git package if miniupnpc is not listed as a dependency:

...

zetacoin-qt-git E: Dependency miniupnpc detected and not included (libraries ['usr/lib/libminiupnpc.so.9'] needed in files ['usr/bin/zetacoin-qt'])

These two facts indicate that miniupnpc should be included as a dependency. I suggest adding a comment to the top of the PKGBUILD explaining why miniupnpc is included as a dependency. [1] https://wiki.archlinux.org/index.php/VCS_PKGBUILD_Guidelines#The_pkgver.28.2... [2] https://github.com/bitcoin/bitcoin/blob/master/doc/build-unix.md

Bruno Jimenez

4:21 p.m.

Hi, Updated version of the PKGBUILD: http://pastebin.com/LRyYqpuZ

...

Whoops, I misread the PKGBUILD. Ignore my suggestion. No, you do not need to add zetacoin-qt-git.install to the `source` and `sha256sums` arrays.

Ok, nothing added then.

...

The `pkgver` you added is OK, but it could be better. The zetacoin git repository has tagged releases, and the wiki states: [1]

...
It is recommended to have following version format: *RELEASE.rREVISION*[...]

Here's a better command for generating a package version number:

...
git describe --long | sed -E 's/([^-]*-g)/r\1/;s/-/./g'

That command generates the following version number:

...
v0.8.2.r218.g5eed859

Added the new package version number. Althought it's a bit strange to see a package whose version starts with 'v'.

...

Consider adding `cd "$srcdir"` to the beginning of the `package()` function.

Please excuse my use of bastardized english. I could have worded my suggestion more clearly.

It was my fault, your english is good, it was just that I didn't understand what you meant me to add. (^_^)

...

The bitcoin docs discuss how to build bitcoin on unix. [2] (zetacoin is based on bitcoin, so the bitcoin docs should be relevant) They state:

...
miniupnpc may be used for UPnP port mapping. It can be downloaded from here. UPnP support is compiled in and turned off by default.

Also, namcap complains about the zetacoin-qt-git package if miniupnpc is not listed as a dependency:

...
zetacoin-qt-git E: Dependency miniupnpc detected and not included (libraries ['usr/lib/libminiupnpc.so.9'] needed in files ['usr/bin/zetacoin-qt'])

These two facts indicate that miniupnpc should be included as a dependency. I suggest adding a comment to the top of the PKGBUILD explaining why miniupnpc is included as a dependency.

Ok, readded it as a dependency and added the comment at the top.

...

[1] https://wiki.archlinux.org/index.php/VCS_PKGBUILD_Guidelines#The_pkgver.28.2... [2] https://github.com/bitcoin/bitcoin/blob/master/doc/build-unix.md

Thanks for all the help! Bruno

Doug Newgard

5:15 p.m.

----------------------------------------

...

From: brunojimen@gmail.com To: aur-general@archlinux.org Date: Sat, 2 Nov 2013 17:21:36 +0100 Subject: Re: [aur-general] PKGBUILD for zetacoin-qt-git

Hi,

Updated version of the PKGBUILD: http://pastebin.com/LRyYqpuZ

...
Whoops, I misread the PKGBUILD. Ignore my suggestion. No, you do not need to add zetacoin-qt-git.install to the `source` and `sha256sums` arrays.

Ok, nothing added then.

...
The `pkgver` you added is OK, but it could be better. The zetacoin git repository has tagged releases, and the wiki states: [1]

...
It is recommended to have following version format: *RELEASE.rREVISION*[...]

Here's a better command for generating a package version number:

...
git describe --long | sed -E 's/([^-]*-g)/r\1/;s/-/./g'

That command generates the following version number:

...
v0.8.2.r218.g5eed859

Added the new package version number. Althought it's a bit strange to see a package whose version starts with 'v'.

You're right, the v shouldn't be there, so strip it. Just add s/^v// to the sed command. The pkgver functions in the Wiki are just suggestions, they need customized for the individual repo you're using.

...

...
Consider adding `cd "$srcdir"` to the beginning of the `package()` function.

Please excuse my use of bastardized english. I could have worded my suggestion more clearly.

It was my fault, your english is good, it was just that I didn't understand what you meant me to add. (^_^)

...
The bitcoin docs discuss how to build bitcoin on unix. [2] (zetacoin is based on bitcoin, so the bitcoin docs should be relevant) They state:

...
miniupnpc may be used for UPnP port mapping. It can be downloaded from here. UPnP support is compiled in and turned off by default.

Also, namcap complains about the zetacoin-qt-git package if miniupnpc is not listed as a dependency:

...
zetacoin-qt-git E: Dependency miniupnpc detected and not included (libraries ['usr/lib/libminiupnpc.so.9'] needed in files ['usr/bin/zetacoin-qt'])

These two facts indicate that miniupnpc should be included as a dependency. I suggest adding a comment to the top of the PKGBUILD explaining why miniupnpc is included as a dependency.

Ok, readded it as a dependency and added the comment at the top.

...
[1] https://wiki.archlinux.org/index.php/VCS_PKGBUILD_Guidelines#The_pkgver.28.2... [2] https://github.com/bitcoin/bitcoin/blob/master/doc/build-unix.md

Thanks for all the help! Bruno

Bruno Jimenez

5:35 p.m.

...

You're right, the v shouldn't be there, so strip it. Just add s/^v// to the sed command.

The pkgver functions in the Wiki are just suggestions, they need customized for the individual repo you're using.

Ok, added it, and now the version is just 0.8.2.r218.g5eed859. If you say it's OK, I'll upload it then. Thanks for all! Bruno

Jeremy Audet

5:25 p.m.

Thanks for your input, Doug. I didn't know that letters were verboten. Other than that one issue, the PKGBUILD looks great to me. On Sat, Nov 2, 2013 at 12:21 PM, Bruno Jimenez wrote:

...

Hi,

Updated version of the PKGBUILD: http://pastebin.com/LRyYqpuZ

...
Whoops, I misread the PKGBUILD. Ignore my suggestion. No, you do not need to add zetacoin-qt-git.install to the `source` and `sha256sums` arrays.

Ok, nothing added then.

...
The `pkgver` you added is OK, but it could be better. The zetacoin git repository has tagged releases, and the wiki states: [1]

...
It is recommended to have following version format: *RELEASE.rREVISION*[...]

Here's a better command for generating a package version number:

...
git describe --long | sed -E 's/([^-]*-g)/r\1/;s/-/./g'

That command generates the following version number:

...
v0.8.2.r218.g5eed859

Added the new package version number. Althought it's a bit strange to see a package whose version starts with 'v'.

...
Consider adding `cd "$srcdir"` to the beginning of the `package()` function.

Please excuse my use of bastardized english. I could have worded my suggestion more clearly.

It was my fault, your english is good, it was just that I didn't understand what you meant me to add. (^_^)

...
The bitcoin docs discuss how to build bitcoin on unix. [2] (zetacoin is based on bitcoin, so the bitcoin docs should be relevant) They state:

...
miniupnpc may be used for UPnP port mapping. It can be downloaded from here. UPnP support is compiled in and turned off by default.

Also, namcap complains about the zetacoin-qt-git package if miniupnpc is not listed as a dependency:

...
zetacoin-qt-git E: Dependency miniupnpc detected and not included (libraries ['usr/lib/libminiupnpc.so.9'] needed in files ['usr/bin/zetacoin-qt'])

These two facts indicate that miniupnpc should be included as a dependency. I suggest adding a comment to the top of the PKGBUILD explaining why miniupnpc is included as a dependency.

Ok, readded it as a dependency and added the comment at the top.

...
[1]

https://wiki.archlinux.org/index.php/VCS_PKGBUILD_Guidelines#The_pkgver.28.2...

...
[2] https://github.com/bitcoin/bitcoin/blob/master/doc/build-unix.md

Thanks for all the help! Bruno

3834

Age (days ago)

3836

Last active (days ago)

List overview

Download

9 comments

3 participants

participants (3)

Bruno Jimenez
Doug Newgard
Jeremy Audet