Re: [aur-general] Proofreading request
On Mon, Aug 26, 2013 at 11:17:16PM +0200, Cl?ment Junca wrote:
Could someone have a look at the attached package, please ? It's my first AUR package written from scratch.
A few additional notes: - Your patch is small. You can use `sed` instead. sed -i 's|env python|env python2|' feather sed -i 's|binpath: /usr/local/bin/|binpath: /usr/bin/|' feather.yaml.dist - Here is a fixed and cleaned version of your `config.install` file: # You should probably run this on install, not on upgrade. # If you want to run this on both install and upgrade, you can do this: # post_install() { # post_upgrade # } post_install() { # Install file output should be dense. echo 'Feather is designed to be run from cron like this:' # The quotation marks are necessary here. Without them, the shell will expand the asterisks. echo ' */5 * * * * /usr/bin/feather /etc/feather.yaml' # 'shall' gives the impression that the file will be updated automatically. echo 'Configuration file /etc/feather.yaml must be updated before running.' } - It is common to name install files after the packages they belong to. You should consider naming your install file `feather.install` or `feather-git.install`.
participants (1)
-
Evan Teitelman