[aur-general] funny-manpages and asr-manpages
Hello, these two packages ( http://aur.archlinux.org/packages.php?ID=3759 and http://aur.archlinux.org/packages.php?ID=3760 ) need to be updated but the original author doesn't reply to my emails. Moreover, the PKGBUILDs have a really horrible indentation. Could someone please orphan them so that I can adopt?
Arkham wrote:
Hello,
these two packages ( http://aur.archlinux.org/packages.php?ID=3759 and http://aur.archlinux.org/packages.php?ID=3760 ) need to be updated but the original author doesn't reply to my emails. Moreover, the PKGBUILDs have a really horrible indentation. Could someone please orphan them so that I can adopt?
Hello Arkham, Both packages have been disowned, so feel free to adopt them. Also, I'd strongly suggest that the PKGBUILDs are re-written from scratch (based on /usr/share/pacman/PKGBUILD.proto) and the dependency on 'man' is dropped (which is just a reader application and doesn't affect the installation/existence of man pages in any way). Cheers. :)
On Sun, Oct 26, 2008 at 8:35 PM, Evangelos Foutras <foutrelis@gmail.com>wrote:
Arkham wrote:
Hello,
these two packages ( http://aur.archlinux.org/packages.php?ID=3759 and http://aur.archlinux.org/packages.php?ID=3760 ) need to be updated but the original author doesn't reply to my emails. Moreover, the PKGBUILDs have a really horrible indentation. Could someone please orphan them so that I can adopt?
Hello Arkham,
Both packages have been disowned, so feel free to adopt them. Also, I'd strongly suggest that the PKGBUILDs are re-written from scratch (based on /usr/share/pacman/PKGBUILD.proto) and the dependency on 'man' is dropped (which is just a reader application and doesn't affect the installation/existence of man pages in any way).
Cheers. :)
I already re-wrote them from scratch :P Going to update them now ;)
On Sun, Oct 26, 2008 at 8:40 PM, Arkham <liuju86@gmail.com> wrote:
On Sun, Oct 26, 2008 at 8:35 PM, Evangelos Foutras <foutrelis@gmail.com>wrote:
Arkham wrote:
Hello,
these two packages ( http://aur.archlinux.org/packages.php?ID=3759 and http://aur.archlinux.org/packages.php?ID=3760 ) need to be updated but the original author doesn't reply to my emails. Moreover, the PKGBUILDs have a really horrible indentation. Could someone please orphan them so that I can adopt?
Hello Arkham,
Both packages have been disowned, so feel free to adopt them. Also, I'd strongly suggest that the PKGBUILDs are re-written from scratch (based on /usr/share/pacman/PKGBUILD.proto) and the dependency on 'man' is dropped (which is just a reader application and doesn't affect the installation/existence of man pages in any way).
Cheers. :)
I already re-wrote them from scratch :P Going to update them now ;)
By the way, these are my third and fourth PKGBUILDs. Could you please take a look at them and tell me if there are any mistakes? Thanks :)
Arkham wrote:
By the way, these are my third and fourth PKGBUILDs. Could you please take a look at them and tell me if there are any mistakes? Thanks :)
They look very good. A couple of really minor issues is omitting to append " || return 1" to the end of `patch' commands (this is necessary for commands that are important to the build and might fail) and utilizing mv/cp/mkdir instead of the more safe `install'. The latter may be seen as a mainly cosmetic change, but can prevent permission problems caused by non-standard umask setting. Additionally, in case you don't know about it, "namcap" is a utility that points out common mistakes found in packages and PKGBUILDs. It's located in the [extra] repo.
On Sun, Oct 26, 2008 at 9:24 PM, Evangelos Foutras <foutrelis@gmail.com>wrote:
They look very good. A couple of really minor issues is omitting to append " || return 1" to the end of `patch' commands (this is necessary for commands that are important to the build and might fail) and utilizing mv/cp/mkdir instead of the more safe `install'. The latter may be seen as a mainly cosmetic change, but can prevent permission problems caused by non-standard umask setting.
Ok, thank you very much for the advices! I've updated the pkgbuilds :) Additionally, in case you don't know about it, "namcap" is a utility that
points out common mistakes found in packages and PKGBUILDs. It's located in the [extra] repo.
I already used that and pacman -Qpil <package> :P
participants (2)
-
Arkham
-
Evangelos Foutras