[PRQ#49231] Merge Request for spflashtool5-bin
dakataca [1] filed a request to merge spflashtool5-bin [2] into spflashtool5 [3]: It would be a good idea to combine the best of both PKGBUILDs, and the same version of spflashtool. [1] https://aur.archlinux.org/account/dakataca/ [2] https://aur.archlinux.org/pkgbase/spflashtool5-bin/ [3] https://aur.archlinux.org/pkgbase/spflashtool5/
Hi dakataca, I also left (part of) this message on the package, just in case you aren't on the mailing list or something. Why exactly was this request created? I don't see a case where these should be merged to be honest. The spflahtool5 [3] package was created way after spflashtol5-bin [2] and I'm unable to see why. The more logical thing seems to be a deletion of spflashtool5 [3] as a duplicate. If you're providing a variant with different options, they shouldn't be merged either; in that case, update it to clearly reflect what the differences are. If you have any suggestions or improvements for spflashtool5-bin [2], feel free to leave a comment there or send me a message. Kind regards, Omar On do, okt 19 2023 at 16:41:35 +00:00:00, notify@aur.archlinux.org wrote:
dakataca [1] filed a request to merge spflashtool5-bin [2] into spflashtool5 [3]:
It would be a good idea to combine the best of both PKGBUILDs, and the same version of spflashtool.
[1] <https://aur.archlinux.org/account/dakataca/> [2] <https://aur.archlinux.org/pkgbase/spflashtool5-bin/> [3] <https://aur.archlinux.org/pkgbase/spflashtool5/>
I've created it so that it doesn't need to compile qtwebkit (very time-consuming), since the package itself contains the necessary
Just got a message back through the AUR comments: libraries. If you notice, the installation times are very different. That means spflashtool5 [3] was created with a specific (different) goal from spflashtool5-bin [2] and is not a pure duplicate. In that case, it should not be removed as one. But it also means they should NOT be merged into each other. Kind regards, Omar On do, okt 19 2023 at 20:27:08 +02:00:00, Omar Pakker <archlinux@opakker.nl> wrote:
Hi dakataca,
I also left (part of) this message on the package, just in case you aren't on the mailing list or something.
Why exactly was this request created? I don't see a case where these should be merged to be honest. The spflahtool5 [3] package was created way after spflashtol5-bin [2] and I'm unable to see why. The more logical thing seems to be a deletion of spflashtool5 [3] as a duplicate. If you're providing a variant with different options, they shouldn't be merged either; in that case, update it to clearly reflect what the differences are.
If you have any suggestions or improvements for spflashtool5-bin [2], feel free to leave a comment there or send me a message.
Kind regards, Omar
On do, okt 19 2023 at 16:41:35 +00:00:00, notify@aur.archlinux.org wrote:
dakataca [1] filed a request to merge spflashtool5-bin [2] into spflashtool5 [3]:
It would be a good idea to combine the best of both PKGBUILDs, and the same version of spflashtool.
[1] <https://aur.archlinux.org/account/dakataca/> [2] <https://aur.archlinux.org/pkgbase/spflashtool5-bin/> [3] <https://aur.archlinux.org/pkgbase/spflashtool5/>
Request #49231 has been Rejected by muflone [1]: spflashtool5 package is a duplicate of spflashtools5-bin package [1] https://aur.archlinux.org/account/muflone/
participants (2)
-
notify@aur.archlinux.org
-
Omar Pakker