Re: [pacman-dev] [PATCH v3] makepkg: fix broken check for the fakeroot binary

On 1/4/19 12:26 AM, Eli Schwartz wrote:

In commit d8ee8d0c99c3820951e2e49dbdb71a5390bd1dc4 we made use of fakeroot absolutely mandatory, and disabled a lot of the code which checked to see if this now-defunct BUILDENV option was set, before setting up the environment to use fakeroot. Unfortunately, we missed one spot.

The check_software routine still checked to see if fakeroot was enabled, but due to the option being removed, thought that it was in fact disabled, and as a result this check would never run.

Fix by checking to see if we are trying to build either a package or a source package, and if so, checking for fakeroot. These are the only two situations where fakeroot is needed.

Signed-off-by: Eli Schwartz ---

v3: as originally reviewed, set BUILDPKG=0 when not actually building package artifacts. I am apparently super tired tonight...

-- Eli Schwartz Bug Wrangler and Trusted User