Re: [pacman-dev] [PATCH] use the default visibility attribute when debugging is enabled, i.e. all symbols will be visible

On Wed, Aug 1, 2012 at 12:53 PM, Barbu Paul - Gheorghe wrote: Why would we want to do this? This could lead to a situation where one makes a production build and breaks an application because a symbol that was available during development disappears. -1 from me for the above reason, and also because a patch that makes a change like this really needs explanation in a commit message, not just a patch subject.

Signed-off-by: Barbu Paul - Gheorghe --- m4/acinclude.m4 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/m4/acinclude.m4 b/m4/acinclude.m4 index f57a515..2829845 100644 --- a/m4/acinclude.m4 +++ b/m4/acinclude.m4 @@ -83,7 +83,8 @@ AC_DEFUN([GCC_VISIBILITY_CC],[ if test $visibility_cv_cc = yes; then AC_DEFINE([ENABLE_VISIBILITY_CC], 1, [Define if symbol visibility C support is enabled.]) fi - AM_CONDITIONAL([ENABLE_VISIBILITY_CC], test "x$visibility_cv_cc" = "xyes") + AM_CONDITIONAL([ENABLE_VISIBILITY_CC], + test "x$visibility_cv_cc" = "xyes" -a "x$debug" != "xyes") fi ])

-- Barbu Paul - Gheorghe Common sense is not so common - Voltaire Visit My GitHub profile to see my open-source projects - https://github.com/paullik