Re: [pacman-dev] [PATCH] Allow version bounds in IgnorePkg entries

On 30/06/15 01:35, Daniel Schoepe wrote:

This patch adds support for ignoring specific version of packages in IgnorePkg. This is useful for ignoring a version that is known to be buggy where a fix is going to be included in the next version. Only equality comparisons (e.g. "foo=1.0-1" or "bar=1.0") are supported.

Signed-off-by: Daniel Schoepe --- NEWS | 2 + doc/pacman.conf.5.txt | 4 +- lib/libalpm/alpm.h | 4 +- lib/libalpm/handle.c | 97 +++++++++++++++++++++++++----------------- lib/libalpm/package.c | 27 ++++++++++-- src/pacman/conf.c | 62 ++++++++++++++++++++------- test/pacman/tests/TESTS | 5 +++ test/pacman/tests/ignore009.py | 14 ++++++ test/pacman/tests/ignore010.py | 13 ++++++ test/pacman/tests/ignore011.py | 13 ++++++ test/pacman/tests/ignore012.py | 13 ++++++ test/pacman/tests/ignore013.py | 13 ++++++ 12 files changed, 205 insertions(+), 62 deletions(-) create mode 100644 test/pacman/tests/ignore009.py create mode 100644 test/pacman/tests/ignore010.py create mode 100644 test/pacman/tests/ignore011.py create mode 100644 test/pacman/tests/ignore012.py create mode 100644 test/pacman/tests/ignore013.py

NEW updates, documentation and testsuite additions! This is awesome already. Note: warning: 1 line adds whitespace errors.

diff --git a/NEWS b/NEWS index a4d3dba..f42a185 100644 --- a/NEWS +++ b/NEWS @@ -3,6 +3,8 @@ VERSION DESCRIPTION 5.0.0 - pacman can check the validity of the local and sync databases (-Dk and -Dkk respectively). This replaces the 'testdb' software + - pacman supports specific version bounds on packages in + IgnorePkg.

That sounds like you can used inequalities - how about: - pacman supports adding a specific version of a package in IgnorePkg The coding and style looks fine. I did not review further based on my comments to your patch cover letter. Allan