Re: [pacman-dev] [PATCH] makepkg: avoid redirecting stdout

On 27/04/13 10:32, Dave Reisner wrote:

If stdout is already redirected, redirecting stderr to stdout can lead to undesirable results.

Fixes FS#34974.

Signed-off-by: Dave Reisner --- This is somewhat of an RFC. Allan and I were unable to discern why this was originally done from git history.

Ack -> maint. I can still think of no reason for this and I have been annoyed by pkgver() catching stderr in the last couple of days (which is my primary motivator to accept patches!)

scripts/makepkg.sh.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index da620a4..838d435 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -1451,7 +1451,7 @@ run_function() { wait $teepid rm "$logpipe" else - $pkgfunc 2>&1 + "$pkgfunc" fi # reset our shell options eval "$shellopts"