On Mon, Oct 26, 2009 at 2:52 AM, Allan McRae
This part should be a separate patch as it appears unrelated to the main patch:
Added quotes to variables in a few places that were missing them or had {} instead
My apologizes for lumping these together. I got another patch in the pipeline to fix an ugly `find` usage...
I have had a brief look through the patch. It sure is long... This bit highlights a concern:
@@ -1900,10 +1898,10 @@ else
msg "$(gettext "Entering fakeroot environment...")"
- if [ -n "$newpkgver" ]; then - fakeroot -- $0 --forcever $newpkgver -F $ARGLIST || exit $? + if [[ -n $newpkgver ]]; then + fakeroot -- "$0" --forcever "$newpkgver" -F "${ARGLIST[@]}" || exit $? else - fakeroot -- $0 -F $ARGLIST || exit $? + fakeroot -- "$0" -F "${ARGLIST[@]}" || exit $? fi fi fi
Part of that is obviously due to a not fully rebased git repo ("${ARGLIST[@]}" changes). As an aside, $newpkgver can never contain a space so quotes are unneeded.
If you are referring specifically to ARGLIST, the ARGLIST variable only appears 3 times in the file. Bases on those 3 occurrences, this change should have no affect other than preserving spaces in arguments (and preserving the $@ as the array it is).