Re: [pacman-dev] [PATCH] makepkg: fix sudo/su calling of pacman

On Wed, Jun 30, 2010 at 6:48 AM, Allan McRae wrote:

Based on patches supplied by Andres P with minor adjustments for suitability for the maint branch.

Signed-off-by: Allan McRae ---

What the fuck do you mean "based"? It's the same exact patch.

This is a fix for the maint branch.  The reworking of the privilege escalation to a configurable option will need to go on the master branch at a later date.

 scripts/makepkg.sh.in |   12 +++++-------  1 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index f3c7217..25bbc74 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -368,17 +368,15 @@ download_file() {  }

 run_pacman() { -       local ret=0 +       local cmd=$(printf "%q " "$PACMAN" $PACMAN_OPTS "$@")

If you're going to NIH all over the place, at least attempt to correct mistakes in my original patch. This should be: local cmd printf -v cmd "%q " "$PACMAN" $PACMAN_OPTS "$@" Also, how do I unsubscribe from this shitty list? ;) Andres P