Re: [pacman-dev] [PATCH] scripts: allow usage when gettext is not installed

On Feb 17, 2008 9:24 PM, Dan McGee wrote:

Address the issue of our scripts not working so great when gettext is not available. This has come up in multiple bug reports, and is relatively easy to address by adding a simple check and a stub function if gettext was not found that simply echos the original message.

Signed-off-by: Dan McGee ---

This issue comes up a lot it seems, so I hope this simple check can fix things up for good. Can anyone see anything wrong with doing this? Quick tests locally seemed to make me think it works? Just rename some gettext calls to something you know does not exist, and change the patch below accordingly to test. Someone with a bit more bash knowledge and checking more complex strings with echo would be good to have here.

I'd like to push this to 3.1.2 if there are no issues, as it is an easy and straightforward fix.

Refs that I forgot to mention: http://bugs.archlinux.org/task/9214 http://bugs.archlinux.org/task/9607