Re: [pacman-dev] [PATCH] Fix double close of the lock file

On 12 February 2011 14:52, Dan McGee wrote:

On Fri, Feb 11, 2011 at 6:51 PM, Jonathan Conder wrote:

...

On 5 February 2011 13:39, Jonathan Conder wrote:

...

According to FOPEN(3), using fclose on an fdopen'd file stream also closes the underlying file descriptor. This happened in _alpm_lckmk (util.c), which meant that when alpm_trans_release closed it again, the log file (which reused the original file descriptor) was closed instead.

Signed-off-by: Jonathan Conder ---

Could I get at least an ack for this please? I sent it a week ago and haven't heard anything.

Yeah I just haven't had a chance to look closely, but I haven't lost track of it.

Ok, thanks. No rush. Jonathan