Re: [pacman-dev] [PATCH] database/print options, fix dirs, other

On Wed, May 19, 2010 at 12:48 AM, Andres P wrote:

On Thu, May 13, 2010 at 9:12 AM, Xavier Chantry wrote:

...

1) Dan is still not happy about license change, even if this is a full rewrite. He would like to have all files in pacman project licensed with GPL2. But if you put this in public domain, I believe Dan could just relicense it in GPL2 himself. Anyway I don't like acting as an intermediary here, hopefully Dan and you can resolve this together.

As you said, my script is under the public domain so everyone is entitled to change and use it as they see fit. ;)

...

2) Related to the directory completion I mentioned earlier : you restored old behavior, which is good. But the old behavior has a bug. It's not a regression in your patch, so not a show stopper, just wondering if you might have an idea. When there is both a directory and a package with the same name, the completion only sees the directory, and thus adds a trailing slash.

$ mkdir acpitool $ pacman -S acpi<tab> acpi      acpid     acpitool/ $ pacman -S acpit<tab> $ pacman -S acpitool/ error: repository 'acpitool' not found error: 'acpitool/': no such repository

This is because -o filenames, which is needed for the 'pkg.tar.*' glob. I have a fix for this that only sets -o filenames when needed.

Patch attached, Andres

Thanks, works for me ! It's a great work you did, that bash completion file was desperately looking for love :) IMO it would be a nice addition to the next release and definitely worth mentioning in the changelog.