Re: [pacman-dev] [PATCH 1/3] makepkg: allow to specify an alternative pacman command

On Thu, Dec 3, 2009 at 6:09 AM, Allan McRae wrote:

Cedric Staniewski wrote:

...

If PACMAN environment variable is set, makepkg will try to use this command to check for installed dependencies and to install or remove packages. Otherwise, makepkg will fall back to pacman.

Implements FS#13028.

Signed-off-by: Cedric Staniewski ---  doc/makepkg.8.txt     |    9 +++++++++  scripts/makepkg.sh.in |   19 +++++++++++--------  2 files changed, 20 insertions(+), 8 deletions(-)

diff --git a/doc/makepkg.8.txt b/doc/makepkg.8.txt index 18ee6ed..703c1b0 100644 --- a/doc/makepkg.8.txt +++ b/doc/makepkg.8.txt @@ -162,6 +162,15 @@ Options        useful if you are redirecting makepkg output to file.   +Environment Variables

Useful Environment Variables?  The lead in sounds better, but maybe not quite right.  Not sure here...

"Environment Variables" is a standard manpage header, usually found near the bottom. I didn't look where this patch actually put it in the manpage, but see examples like less, grep, etc.

...

+--------------------- +*PACMAN*:: +       The command which will be used to check for missing dependencies and to +       install and remove packages. Pacman's -U, -T, -S and -Rns operations +       must be supported by this command. If the variable is not set or +       empty, makepkg will fall back to `pacman'.

The command _that_ will...  The rest of the description sounds fine.

Otherwise, the patch is good.