On 16/04/13 09:55 PM, Allan McRae wrote:
You provide details for many things that are not changed at all by the patch. Just detail what is changed (ALPM_QUESTION_INSTALL_IGNOREPKG).
I wouldn't've written all that if I were just setting *response = 1 in that case and returning. But I am setting *response = 0 in all other cases because previous discussion was leaning towards the view that the frontend should know what is going to happen no matter what the question is.
If that is dead code, why propagate it? It should just be removed altogether (in another commit...). Which would leave a fairly redundant case statement.
ALPM_QUESTION_IMPORT_KEY was dead code up until a few commits ago... but yeah ALPM_QUESTION_LOCAL_NEWER is almost certainly not part of upcoming plans.