Re: [pacman-dev] [PATCH] src/pacman/sync.c : cleanup of pacman_sync

2008/6/2 Nagy Gabor :

...

...

@@ -861,7 +823,43 @@ int pacman_sync(alpm_list_t *targets) return(sync_list(sync_dbs, targets)); }

- return(0); + if(targets == NULL) { + if(config->op_s_sync) { + return(0);

I may overlook something, but won't this break -Syu?

Oops, you are right, good catch. I probably got confused because op_s_sync used to get resetted after doing the -y operation, but I removed that part : - config->op_s_sync = 0;

So now, I could probably just invert the order of these two checks : do s_upgrade check first, then s_sync. Does that sound alright?

Yes. Bye ---------------------------------------------------- SZTE Egyetemi Könyvtár - http://www.bibl.u-szeged.hu This mail sent through IMP: http://horde.org/imp/