On Mon, Jul 23, 2007 at 08:18:58PM +0100, Andrew Fyfe wrote:
If Root isn't specified, paths like (null)var/ will be created. I think pacman should either default to / for Root, or just fail if it isn't set.
The backend (although I think this is a frontend problem :) should do
if ( stat(rootdir, &buf) != 0 || ! S_ISDIR(&buf->st_mode) ) Ooops invalid root directory....
Doesn't the frontend already default to / or are you talking about a case where rootdir='' in pacman.conf?
It doesn't default to / anymore (in git), but I think it would be better if it did (maybe in the frontend). The case of an invalid rootdir in pacman.conf could be caught by a sanity check (maybe in the backend). Anyway, I'm not sure in which place they should be, but I believe that sane defaults + sanity checks is an important thing to have.