Re: [PATCH 2/2] alpm version diff coloring

On 1/3/22 15:02, David Gustavsson wrote:

Use non-alphanumerics as branching points for diff coloring.

Signed-off-by: David Gustavsson ---

There is a memory leak somewhere in here: $ sudo ./build/pacman -Su :: Starting full system upgrade... resolving dependencies... looking for conflicting packages... free(): invalid next size (fast) Aborted I have not looked for it yet, because I am still deciding the utility of these patches. For discussion, consider these versions: 5.18.14.arch1-1 5.18.15.arch1-1 With the first patch in this series applied (have not looked to see if this changes with the second), this starts highlighting after "5.18.1". But if we were going from 5.18.9 to 5.18.10, it would highlight after the "5.18.". These upgrades are no different in that versioning scheme. This should definitely always highlight from the version level separator. Also, I personally do not find this colouring useful, but I also do not find the verbose package lists before update useful... So I am open to opinions on this. Here is an example of the output after the patch 1/2 applied: http://allanmcrae.com/tmp/pacman-version-change-highlight.png I'll wait for more feedback before looking into this further. Allan