Re: [pacman-dev] [PATCH] Add AM_MAINTAINER_MODE to configure.ac and disable by default

On 03/02/15 12:11, Allan McRae wrote:

We had issues with people trying to build the 4.2.0 tarball while not having automake-1.14 installed. This appears to be due to timestamp issues resulting in autotools trying to regenerate various files and then the Makefiles deciding they need specific versions of automake.

This can be fixed by adding AM_MAINTAINER_MODE([disable]) to configure.ac, which means that any build will not try and rebuild any build scripts unless explicitly requested.

Pacman developers can consider using --enable-maintainer-mode when running configure to use autotools to update build scripts as needed.

Signed-off-by: Allan McRae ---

That is a long explanation for a single line change!

It turns out the bug is due to the TESTS file being updated due to sync200.py.in creating sync200.py. This patch is a workaround, but not a real fix (not sure what a real fix is...). It does require developers to use --enable-maintainer-mode when configuring to get all the auto-regen goodness. Are there objections to applying this patch - at least until a proper solution is found?

configure.ac | 1 + 1 file changed, 1 insertion(+)

diff --git a/configure.ac b/configure.ac index e0ed3cf..f17ae89 100644 --- a/configure.ac +++ b/configure.ac @@ -62,6 +62,7 @@ AC_REQUIRE_AUX_FILE([tap-driver.sh]) AC_CANONICAL_HOST AM_INIT_AUTOMAKE([1.11 foreign]) AM_SILENT_RULES([yes]) +AM_MAINTAINER_MODE([disable])

LT_INIT LIB_VERSION=`expr lib_current - lib_age`.lib_age.lib_revision