Re: [pacman-dev] [PATCHv3 1/3] makepkg: Use read to parse status file during signature verification.

Am 23.05.2014 07:32, schrieb Allan McRae:

...

...

- if ! $decompress < "$sourcefile" | gpg --quiet --batch --status-file "$statusfile" --verify "$file" - 2> /dev/null; then + $decompress < "$sourcefile" | gpg --quiet --batch --status-file "$statusfile" --verify "$file" - 2> /dev/null

Comment added:

# these variables are assigned values in parse_gpg_statusfile

...

...

+ success=0 + status= + pubkey= + parse_gpg_statusfile "$statusfile"

Before this actually gets merged, could we add a comment that parse_gpg_statusfile modifies the "local" variables success, status, and pubkey? This behavior is non-obvious and makes the following test confusing.

I don't particularly like this method. Is there a more obvious method for passing this data?