Re: [pacman-dev] [PATCH 2/2] copy file siglevels from SigLevel when first seen

On 31/10/13 21:45, Andrew Gregory wrote:

On 10/31/13 at 04:13pm, Allan McRae wrote:

...

On 28/10/13 23:58, Andrew Gregory wrote:

...

Both repo-specific siglevels and file siglevels used the default siglevel as their base. Previously, repo siglevels inherited when the repo was parsed, but file siglevels inherited after config parsing was complete. Having both options inherit from the default when they are first parsed is more intuitive and reduces parser complexity.

Signed-off-by: Andrew Gregory ---

This may change how some existing config files are parsed, but I doubt anybody is purposefully using the old behavior.

Can you provide details of the old behaviour that is "broken" by this?

Sure, here's an example:

SigLevel = Required TrustedOnly RemoteFileSigLevel = Optional SigLevel = TrustAll

Old behavior: RemoteFileSigLevel's final value is Optional TrustAll. New behavior: RemoteFileSigLevel's final value is Optional TrustedOnly.

I'm happy to break that. Perhaps we should consider SigLevel being specified twice in a pacman.conf as an error. It does not seem like a good idea to allow that as people would just see the first one when scanning their pacman.conf file. A