Small bug fix. Andrew Fyfe wrote:
I was looking at the commented out code in makepkg to unset all vars in PKGBUILD before including and I think I've cracked it. So I went to test it on arch's main, extra and unstable repo, and there's several PKGBUILDs with miss spelled vars.
As a result I've created check-buildscript, this just runs some sanity/spell checks on a PKGBUILD script. People should run it before submitting a PKGBUILD.
Andrew
------------------------------------------------------------------------
_______________________________________________ pacman-dev mailing list pacman-dev@archlinux.org http://www.archlinux.org/mailman/listinfo/pacman-dev
From 2ff98926b6c8648f7aadede27e981dad6644e524 Mon Sep 17 00:00:00 2001 From: Andrew Fyfe <andrew@neptune-one.net> Date: Thu, 29 Mar 2007 16:38:07 +0100 Subject: [PATCH 2/2] Fixed infinite loop in options check.
Signed-off-by: Andrew Fyfe <andrew@neptune-one.net> --- scripts/check-buildscript | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/scripts/check-buildscript b/scripts/check-buildscript index fddd2bf..fef8ca6 100755 --- a/scripts/check-buildscript +++ b/scripts/check-buildscript @@ -220,6 +220,8 @@ while true; do --) OPTIND=0; shift; break;; *) usage; exit $E_UNKNOWN;; esac + + shift done if [ $# -eq 0 ]; then -- 1.5.0.6