Re: [pacman-dev] [PATCH v2] PKGBUILD.5.txt: Clarify note about variables available

On 27/02/15 10:01, Johannes Löthberg wrote:

Reported-by: Florian Pritz Signed-off-by: Johannes Löthberg --- Fix 'available' typo. (Gah, that's embarassing.) doc/PKGBUILD.5.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/doc/PKGBUILD.5.txt b/doc/PKGBUILD.5.txt index 86bf63a..fed49b9 100644 --- a/doc/PKGBUILD.5.txt +++ b/doc/PKGBUILD.5.txt @@ -367,9 +367,9 @@ the `build()` function. `package()` functions. Be sure any exotic commands used are covered by the `checkdepends` array.

-All of the above variables such as `$pkgname` and `$pkgver` are available for -use in the `build()` function. In addition, makepkg defines the following -variables for use during the build and install process: +All of the above variables such as `$pkgname` and `$pkgver`, in addition to the +following ones, are available for use in all of the above defined packaging +functions.

I think the two sentence version reads more clearly. Also, $pkgdir should only be used in package(), so it is easier not to state where they should be used. How about: All of the above variables such as `$pkgname` and `$pkgver` are available for use in the packaging functions. In addition, makepkg defines the following variables:

*srcdir*:: This contains the directory where makepkg extracts, or copies, all source