Re: [pacman-dev] [PATCH] diskspace: add the actually used statfs type in ifdefs

On Mon 04 April 2011 at 23:39 -0500, Dan McGee wrote:

On Mon, Apr 4, 2011 at 6:37 PM, Rémy Oudompheng wrote:

...

Some systems, like FreeBSD might define both statfs and statvfs: however if statvfs exists whereas getmntinfo() uses a statfs struct, the current ifdefs would select the wrong line of code.

Signed-off-by: Rémy Oudompheng --- Rework of a previous patch. autoconf no longer spews errors on Linux, but still complains on FreeBSD + autoconf 2.68 I don't know how to fix that, but the errors also appear with current maint branch.

Giving us the errors here might help correct them. We also haven't made that many changes to configure.ac between master and maint, so I'm not sure if you're saying master is fine or what. I'm hesitant to merge this patch just yet since I don't know what we're looking at problem-wise here.

The warnings are: configure.ac:185: warning: AC_CACHE_VAL(path_max_cv_defined, ...): suspicious cache-id, must contain _cv_ to be cached ../../lib/autoconf/general.m4:2032: AC_CACHE_VAL is expanded from... ../../lib/autoconf/general.m4:2053: AC_CACHE_CHECK is expanded from... acinclude.m4:129: PATH_MAX_DEFINED is expanded from... configure.ac:185: the top level configure.ac:196: warning: AC_CACHE_VAL(fs_stats_cv_type, ...): suspicious cache-id, must contain _cv_ to be cached ../../lib/autoconf/general.m4:2032: AC_CACHE_VAL is expanded from... ../../lib/autoconf/general.m4:2053: AC_CACHE_CHECK is expanded from... acinclude.m4:105: FS_STATS_TYPE is expanded from... configure.ac:196: the top level configure.ac:207: warning: AC_CACHE_VAL(gnu89_inline_cv_cc, ...): suspicious cache-id, must contain _cv_ to be cached ../../lib/autoconf/general.m4:2032: AC_CACHE_VAL is expanded from... ../../lib/autoconf/general.m4:2053: AC_CACHE_CHECK is expanded from... acinclude.m4:87: GCC_GNU89_INLINE_CC is expanded from... configure.ac:207: the top level They happen on the clean maint and master branches, and don't make any sense to me, but they are not related to this patch anyway. I'm not sure about what version of m4 is used there, I'll look at that later. -- Rémy.