Allan McRae wrote:
Xavier wrote:
Xavier Chantry wrote:
pacman already localizes the yesno stuff, so doing the same in makepkg is more consistent.
Signed-off-by: Xavier Chantry <shiningxc@gmail.com> --- scripts/makepkg.sh.in | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index b810d60..4192af8 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -1211,10 +1211,11 @@ if [ "$CLEANCACHE" = "1" ]; then #fix flyspray feature request #5223 if [ -n "$SRCDEST" -a "$SRCDEST" != "$startdir" ]; then msg "$(gettext "Cleaning up ALL files from %s.")" "$SRCDEST" - echo -n "$(gettext " Are you sure you wish to do this? [Y/n] ")" + echo -n "$(gettext " Are you sure you wish to do this? ")" + echo -n "$(gettext "[Y/n]")" read answer - answer=$(echo $answer | tr '[:upper:]' '[:lower:]') - if [ "$answer" = "yes" -o "$answer" = "y" ]; then + answer=$(echo $answer | tr '[:lower:]' '[:upper:]') + if [ "$answer" = $(gettext "YES") -o "$answer" = $(gettext "Y") ]; then
Doesn't the $(gettext "blah") need to be in quotes?
I have to admit I didn't even pay attention to that. But in this case, it shouldn't be needed, at least for every languages which translate yes and y in one word. But just for safety and consistency, I should have put quotes there.