8*?) Tidy up bash_completion stuff? (FS#16630) The poster disappeared and he tried to sneak a license change in there, so that just hit a bit of a roadblock. I'd like to improve
so I might just sit down and hack at it myself. "Tried to sneak a license change"? From your own ml: On Tue, Jan 19, 2010 at 11:48 PM, Andres Perera <andres...@gmail.com> wrote:
On Wed, Jan 20, 2010 at 1:07 AM, Dan McGee <dpmc...@gmail.com> wrote:
Is this strictly necessary? You are changing one piece of code in
On 05/05/10 at 18:31:22 CEST, Dan McGee <dpmcgee at gmail.com> wrote: this the
entire codebase to require v3 or later and as weird as it sounds, I am not going to let that fly. I won't be merging this unless it is v2 or you give some darn good reasons why we should move to v3. Not really necessary. You can change it to v2, or I can do that if it requires a commit from me. Nah that's good enough for me. I'll try to give this whole thing a workout in the next day or two and see if I can come up with anything else that we might want to tweak, however. -Dan http://www.mail-archive.com/pacman-dev@archlinux.org/msg04127.html Maybe I was a little harsh? Anyway, I don't care if you put a random bash script I wrote ages ago under GPL, Public Domain, BSD... lol, Andres P
On Sat, May 8, 2010 at 5:44 AM, Andres P <stderr@mail.com> wrote:
http://www.mail-archive.com/pacman-dev@archlinux.org/msg04127.html
Maybe I was a little harsh?
Anyway, I don't care if you put a random bash script I wrote ages ago under GPL, Public Domain, BSD...
Nah, Dan was just looking for bad excuses why he didn't get this done earlier. ahah :) More likely, what happened is that he planned to work on this patch to review/improve it, and so he could have fixed the license change in the same time. But he didn't have the time to do it right away, and looking at it months later, he forgot you already gave your agreement to keep the license. Maybe just to be safe, it would have been better not to change the license from the start, even for a big rewrite. Btw the list of fixes and performance improvements does look nice, and the diff looks nice too. contrib/bash_completion | 535 ++++++++++++++++++----------------------------- 1 files changed, 202 insertions(+), 333 deletions(-) Now that I am back on bash, I suppose I could give that a try. Thanks for your work !
participants (2)
-
Andres P
-
Xavier Chantry