[arch-dev-public] Improving/Simplifying Kernel PKGBUILD

Aaron Griffin aaronmgriffin at gmail.com
Tue Nov 13 13:16:27 EST 2007


On Nov 12, 2007 7:19 PM, James Rayner <iphitus at gmail.com> wrote:
> Some people liked this idea...
>
> http://cvs.archlinux.org/cgi-bin/viewcvs.cgi/base/kernel26/PKGBUILD?rev=1.273&content-type=text/vnd.viewcvs-markup
>
> - We could put the patches into a patchset. tpowa has expressed dislike
> for this idea before, though it actually makes it easier to maintain. It'd
> allow the documentation to be moved out of the PKGBUILD, make the patches
> more accessible and the PKGBUILD cleaner.
>
> The only other things I can think of have alarm bells and are covered in
> red paint. Any other ideas?

Would it be more clear to do something like:

patches=(foo bar)
sources=(blah ${sources[@]})

build() {
....
    for p in ${patches[@]}; do
        patch ......
    done
....
}

Just a thought




More information about the arch-dev-public mailing list