[arch-dev-public] Improving/Simplifying Kernel PKGBUILD

[Dan McGee]

On Nov 13, 2007 12:16 PM, Aaron Griffin <aaronmgriffin at gmail.com> wrote:
> On Nov 12, 2007 7:19 PM, James Rayner <iphitus at gmail.com> wrote:
> > Some people liked this idea...
> >
> > http://cvs.archlinux.org/cgi-bin/viewcvs.cgi/base/kernel26/PKGBUILD?rev=1.273&content-type=text/vnd.viewcvs-markup
> >
> > - We could put the patches into a patchset. tpowa has expressed dislike
> > for this idea before, though it actually makes it easier to maintain. It'd
> > allow the documentation to be moved out of the PKGBUILD, make the patches
> > more accessible and the PKGBUILD cleaner.
> >
> > The only other things I can think of have alarm bells and are covered in
> > red paint. Any other ideas?
>
> Would it be more clear to do something like:
>
> patches=(foo bar)
> sources=(blah ${sources[@]})
sources=(blah ${patches[@]}) :P

>
> build() {
> ....
>     for p in ${patches[@]}; do
>         patch ......
>     done
> ....
> }
>
> Just a thought

If we do the above, and then move all comments about the patches to a
separate patches.list file where each could be explained, would that
be smart? Or would that be weird (having a file in ABS/CVS that isn't
actually needed for building a package).

-Dan