[arch-dev-public] Code review: dbscripts

Thomas Bächler thomas at archlinux.org
Wed Sep 3 04:03:10 EDT 2008

Aaron Griffin schrieb:
>> http://projects.archlinux.org/?p=dbscripts.git;a=commitdiff;h=06194a8691f50ffc9130795e16837496e13dd08f
>> There is a problem here: rm -f "$srcpath/${pkgname}-*-*${SRCEXT}"
>> If you run this with mplayer, this will not only remove old mplayer
>> packages, but also mplayer-plugin (think of more examples if you want).
>> That's the reason I am using the ugly getpkgname in the cleanup scripts (or
>> was using it, dunno if it is still there).
> That's a very good point. Could you suggest a cleaner way to clean up
> existing tarballs?
> How about:
> for srcpkg in $pkgname*; do
>    [ "$(getpkgname $srcpkg)" == "$pkgname" ] && rm -f "$srcpkg"
> done

That should work, if we make sure the getpkgname function parses the 
filename properly.

>> http://projects.archlinux.org/?p=dbscripts.git;a=commitdiff;h=e1ad729fd49c630eece0055ed996b382811a836c
>> This includes unstable and lacks community.
> Removed unstable... community, however, is another beast that I wanted
> to avoid thinking about for now... adding that might tip us over the
> disk space limit on gerolde.

I thought we had enough donation money left, if so, just get another 
hard drive.

> For the record, I have not moved existing source tarballs to
> /home/ftp/sources/ yet, because I fear it may force our mirrors to
> sync those as well... does anyone with more rsync knowledge want to
> check to see if this will happen? I'd like to add a stanza for JUST
> the sources and exclude if from elsewhere, making it optional...

Depends on what they sync. The "ftp" module contains "exclude = 
/archive/ /other/", while the "ftpfull"/"kitchensink" module doesn't 
have an exclude line. We could add exclude = /sources to kitchensink, 
ftpfull and ftp, so that they'd have to explicitly sync the "sources" 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 260 bytes
Desc: OpenPGP digital signature
URL: <http://archlinux.org/pipermail/arch-dev-public/attachments/20080903/40f2f250/attachment.pgp>

More information about the arch-dev-public mailing list