[arch-dev-public] RFC: Dropping -DCMAKE_BUILD_TYPE from packages using cmake
bruno.n.pagani at gmail.com
Sat Mar 10 13:34:16 UTC 2018
Le 10/03/2018 à 11:34, Antonio Rojas via arch-dev-public a écrit :
> Currently most of our packages which use the cmake build system are built with -DCMAKE_BUILD_TYPE=Release. This provides a reasonable (according to upstream) set of C(XX)FLAGS defaults which are appended to and override our default C(XX)FLAGS. So, for instance, our cmake packages are being built with -O3 instead of our default -O2. Besides the inconsistency that this brings to our binaries, IMO it's not a good idea to override our default C(XX)FLAGS unless there's a good reason to. This will also cause issues once we start building debug packages by default (-DCMAKE_BUILD_TYPE=Release also adds DNDEBUG).
> Therefore I'm proposing to drop -DCMAKE_BUILD_TYPE from all our cmake packages, building them with our default C(XX)FLAGS as all other packages. Comments?
As long as you accept exceptions to this (I have scientific stuff in
mind, like NetCDF — currently not built with CMake but will be in next
release), I’m fine with this.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 520 bytes
Desc: OpenPGP digital signature
More information about the arch-dev-public