[arch-general] split packages: basic assumptions about $pkgname in prepare() and build()

[Martti Kühne]

guys

so, this morning I made the mistake to try building a random split
package PKGBUILD from ABS with the --pkg flag.

==> Starting prepare()...
/home/martti/abs/systemd/PKGBUILD: line 33: cd: libsystemd-212: No
such file or directory
==> ERROR: A failure occurred in prepare().
    Aborting...

Wait a minute, really?

After building a little tool to find packages that use $pkgname in
prepare()/build() despite the fact that $pkgname isn't *necessarily*
the right thing to use to build their source paths, I'm revealed 53 of
a total of 400 split packages appear to be using that variable in
building. Which equates to a good one in every eighth PKGBUILD of the
split packages ecosystem.

Now, sure, makepkg could mitigate this problem by setting $pkgname to
$pkgbase for the execution of prepare() and build(), but this would
first have to be instroduced upstream.

My findings are listed below.

cheers!
mar77i


/var/abs/core/systemd/PKGBUILD
/var/abs/core/util-linux/PKGBUILD

/var/abs/testing/pidgin/PKGBUILD
/var/abs/testing/systemd/PKGBUILD
/var/abs/testing/vim/PKGBUILD

/var/abs/community/python-prettytable/PKGBUILD
/var/abs/community/man-pages-zh/PKGBUILD
/var/abs/community/luarocks/PKGBUILD
/var/abs/community/grails/PKGBUILD
/var/abs/community/python-werkzeug/PKGBUILD
/var/abs/community/marisa/PKGBUILD
/var/abs/community/python-flask/PKGBUILD
/var/abs/community/tesseract/PKGBUILD
/var/abs/community/protobuf/PKGBUILD
/var/abs/community/lua-alt-getopt/PKGBUILD
/var/abs/community/python-urllib3/PKGBUILD
/var/abs/community/python-mysql-connector/PKGBUILD
/var/abs/community/jack2/PKGBUILD
/var/abs/community/python-biopython/PKGBUILD
/var/abs/community/python-jsonschema/PKGBUILD
/var/abs/community/python-jsonpointer/PKGBUILD
/var/abs/community/python-pbr/PKGBUILD
/var/abs/community/bird/PKGBUILD
/var/abs/community/xe-guest-utilities/PKGBUILD
/var/abs/community/python-httplib2/PKGBUILD
/var/abs/community/rxvt-unicode/PKGBUILD
/var/abs/community/qstardict/PKGBUILD
/var/abs/community/notmuch/PKGBUILD
/var/abs/community/python-sh/PKGBUILD
/var/abs/community/python-jsonpatch/PKGBUILD
/var/abs/community/scala/PKGBUILD

/var/abs/community-testing/rxvt-unicode/PKGBUILD

/var/abs/extra/hyphen/PKGBUILD
/var/abs/extra/pangomm/PKGBUILD
/var/abs/extra/hspell/PKGBUILD
/var/abs/extra/postfix/PKGBUILD
/var/abs/extra/python-virtualenv/PKGBUILD
/var/abs/extra/glibmm/PKGBUILD
/var/abs/extra/bluez/PKGBUILD
/var/abs/extra/oxygen-icons/PKGBUILD
/var/abs/extra/lapack/PKGBUILD
/var/abs/extra/qemu/PKGBUILD
/var/abs/extra/elementary/PKGBUILD
/var/abs/extra/efl/PKGBUILD
/var/abs/extra/pidgin/PKGBUILD
/var/abs/extra/redland/PKGBUILD
/var/abs/extra/xsane/PKGBUILD
/var/abs/extra/python-pip/PKGBUILD
/var/abs/extra/gnome-desktop-sharp/PKGBUILD
/var/abs/extra/opencv/PKGBUILD
/var/abs/extra/vim/PKGBUILD
/var/abs/extra/digikam/PKGBUILD
/var/abs/extra/ocaml/PKGBUILD