[arch-projects] [netcfg] [PATCH 2/4] Remove extra start_wpa/stop_wpa when not scanning

Henrik Hallberg henrik at k2h.se
Mon Jul 2 21:00:21 EDT 2012

On Tue, Jul 03, 2012 at 01:16:07AM +0200, Jouke Witteveen wrote:
> These changes look fine to me, but shitty code remains shitty code.
> I'm not a big fan of the current organization of the code and the
> distribution across connections/wireless and 8021x.

So far, it has seemed better to submit small patches rather than larger
ones. I could very well have spent time doing a larger refactoring. It
seems to me, however, that I am not yet enough versed in the code and
its' style to make an attempt with reasonable chances to pass review.

This solves the problem of the extra calls only. A small, easily
reviewable patch. The code behaves better with it, than without it.

/ H

More information about the arch-projects mailing list