[arch-projects] [netcfg] [PATCH 2/4] Remove extra start_wpa/stop_wpa when not scanning
j.witteveen at gmail.com
Mon Jul 2 21:11:26 EDT 2012
On Tue, Jul 3, 2012 at 3:00 AM, Henrik Hallberg <henrik at k2h.se> wrote:
> On Tue, Jul 03, 2012 at 01:16:07AM +0200, Jouke Witteveen wrote:
>> These changes look fine to me, but shitty code remains shitty code.
>> I'm not a big fan of the current organization of the code and the
>> distribution across connections/wireless and 8021x.
> So far, it has seemed better to submit small patches rather than larger
> ones. I could very well have spent time doing a larger refactoring. It
> seems to me, however, that I am not yet enough versed in the code and
> its' style to make an attempt with reasonable chances to pass review.
> This solves the problem of the extra calls only. A small, easily
> reviewable patch. The code behaves better with it, than without it.
> / H
There's some comments in lines 73-75. They were ignored in commit
0d4c3. Reverting said commit would solve this problem too. Any
thoughts what would be better? I like the old code, but the commit
message suggests that wpa_supplicant doesn't reassociate properly (at
least, that it didn't back then). If wpa_supplicant has improved, I'm
in favor of restoring the old code, which looks more reasonable to me.
Otherwise, the proposed patch will do.
More information about the arch-projects