[arch-projects] [INITSCRIPTS][PATCH 4/6] Use bash case modification to check yes/no

Igor M Podlesny for.poige+archlinux at gmail.com
Tue Jun 12 05:01:41 EDT 2012


On 12 June 2012 05:10, Sébastien Luttringer <seblu at seblu.net> wrote:
> Signed-off-by: Sébastien Luttringer <seblu at seblu.net>
> ---
>  rc.shutdown |    6 +++---
>  rc.sysinit  |    6 +++---
>  2 files changed, 6 insertions(+), 6 deletions(-)
[…]

   It's worse that mine
https://bitbucket.org/poige/arch-initscripts/changeset/1c05cbfa92cf
not just due to it's neither mentioning this my efforts commited nor
using lowercase "yes" instead of uppercase, but mostly and mainly due
to it's bad programming practice/style. Special function, specially
named to be be clear and readable in plain is way better. In addition
you can easily transform this to /bin/sh or change the way it
compares, just because it's more flexible — you wouldn't have to
replace all occurrences, just one — inside isYes(). It's not OOP, it's
just old as IT subroutines.

-- 
End of message. Next message?


More information about the arch-projects mailing list