[arch-projects] [INITSCRIPTS][PATCH 4/6] Use bash case modification to check yes/no
d at falconindy.com
Tue Jun 12 06:16:56 EDT 2012
On Tue, Jun 12, 2012 at 05:01:41PM +0800, Igor M Podlesny wrote:
> On 12 June 2012 05:10, Sébastien Luttringer <seblu at seblu.net> wrote:
> > Signed-off-by: Sébastien Luttringer <seblu at seblu.net>
> > ---
> > rc.shutdown | 6 +++---
> > rc.sysinit | 6 +++---
> > 2 files changed, 6 insertions(+), 6 deletions(-)
> It's worse that mine
> not just due to it's neither mentioning this my efforts commited nor
> using lowercase "yes" instead of uppercase, but mostly and mainly due
> to it's bad programming practice/style. Special function, specially
> named to be be clear and readable in plain is way better. In addition
> you can easily transform this to /bin/sh or change the way it
> compares, just because it's more flexible — you wouldn't have to
> replace all occurrences, just one — inside isYes(). It's not OOP, it's
> just old as IT subroutines.
> End of message. Next message?
When you figure out how to use git-send-email, I might consider valuing
your opinion about such trivial matters. You might also consider that
1) doesn't apply to master
2) adds dead code
3) uses camelCase where we use lower_case everywhere else
4) fails to quote properly
It's not "IT subroutines", it's about showing some respect for other
people in the community of which you're rather new to.
Please go away.
More information about the arch-projects