[arch-projects] [dbscripts] [GIT] Official repo DB scripts branch master updated. 20131102-81-g8cc8e9c

eschwartz at archlinux.org eschwartz at archlinux.org
Thu Mar 22 01:02:37 UTC 2018

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Official repo DB scripts".

The branch, master has been updated
       via  8cc8e9cbbefdf6fac368031d3dacc74d001f23b7 (commit)
       via  0432cffc42040f852b9a55c27316248da9064b67 (commit)
       via  36087fbd8b030fa6f908fdbb667292e3c078b615 (commit)
       via  23c2b82c336bf19b7a29a90d19bca4423d8b8839 (commit)
       via  97e17a5996425e8b7c3c1765a3c5074e1c4ff38d (commit)
       via  9672d6ec64ff5773df4b22bca9f2da44303dc03f (commit)
       via  41333413f19e025d800e02c83511b85bee65ac60 (commit)
       via  5c867ea3b857cba0993fc18e064c6f02f70ee099 (commit)
      from  da49ea616e162d3cfcb4b6a4242f497e94c36564 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 8cc8e9cbbefdf6fac368031d3dacc74d001f23b7
Author: Luke Shumaker <lukeshu at parabola.nu>
Date:   Wed Jun 18 20:33:06 2014 -0400

    Clean up printf-formatters for user messages
     - db-functions: getpkgfile: The .sig file extension should be part of
       the filename parameter, not part of the message format string.
     - db-functions: arch_repo_modify: Shouldn't use ${action}
       string-interpolation in the message format string.  Since the
       entire message is a command, and we're using @Q to escape arguments
       anyway, go ahead and just construct the entire command as a single
       string that way, and feed it to '%s'.

commit 0432cffc42040f852b9a55c27316248da9064b67
Author: Luke Shumaker <lukeshu at parabola.nu>
Date:   Wed Jun 18 12:07:09 2014 -0400

    Fixups near unquoted variables
    Using the following command to find unquoted variables (and ignoring
    more than a a few false positives),
        grep -Prn --exclude-dir=.git '(?<!["=]|\[\[ |\[\[ -[zn] )\$(?!{?#|\(|\? )'
    one is lead to find a few cleanups that are something other than "add
    double-quotes".  That's what these are.  We'll leave dumb adding of
    double-quotes for another commit.
    Most of these are still fixing quoting issues, just with a better fix.
     - parse_pkgbuilds.sh: Avoid having to escape quotes in `eval` strings
       by using `declare -p`. Updates the logic copied from makepkg, with the
       latest logic copied from makepkg. See
     - sourceballs: Avoid using ary=($string) to do field separation by
       using `read` and test that multiple licenses actually work as
     - sourceballs: Replace `[[ -z ${ary[*]} ]]` with test for the array
     - db-functions: Replace mangling echo field separators using sed, with
       printf formatters
     - db-functions: Replace for/echo loop to print an array line by line,
       with `printf '%s\n'`
     - db-functions: set_repo_permissions: Line up error messages, quote
     - db-move: Replace `$(echo ${array[@]})` with `${array[*]}`
     - testing2x: Use `"$@"` instead of `$*` when looping over an array
    Also, not really quoting related but on the same line as a quoting
    issue, optimize:
     - db-functions: Replace
    	[[ -n "$(... | sort | uniq -D)" ]]
    	! ... | awk 'a[$0]++{exit 1}'

commit 36087fbd8b030fa6f908fdbb667292e3c078b615
Author: Luke Shumaker <lukeshu at parabola.nu>
Date:   Wed Mar 14 16:52:05 2018 -0400

    Remove uses of the "v=true; if $v ..." anti-pattern
    Instead, compare the value of $v to 'true'.

commit 23c2b82c336bf19b7a29a90d19bca4423d8b8839
Author: Luke Shumaker <lukeshu at parabola.nu>
Date:   Sun Apr 17 12:18:02 2016 -0400

    Don't use `grep -q` when operating on piped stdin
    (By default, prefer `grep &>/dev/null`)
    `grep -q` may exit as soon as it finds a match; this is a good optimization
    for when the input is a file.  However, if the input is the output of
    another program, then that other program will receive SIGPIPE, and further
    writes will fail.  When this happens, it might (bsdtar does) print a
    message about a "write error" to stderr.  Which is going to confuse and
    alarm the user.
    In one of the cases (in common.bash, in the test suite), this had
    already been mitigated by wrapping bsdtar in "echo "$(bsdtar ...)", as
    Bash builtin echo doesn't complain if it gets SIGPIPE.  However, that
    means we're storing the entire output of bsdtar in memory, which is
    silly.  Additionally, the way it was implemented is also wrong;
    because it was being used with `grep -qv` instead of just `grep -q`,
    it *always* found a non-matching line (even something inconsequential
    like `%NAME%`), and *never* triggered a test failure.
    Looking at a few of these cases, it might also make sense to switch to
    using `bsdtar tf` instead of `bsdtar xf` when checking membership, but
    that's work for another day.

commit 97e17a5996425e8b7c3c1765a3c5074e1c4ff38d
Author: Luke Shumaker <lukeshu at parabola.nu>
Date:   Sun Apr 17 02:07:26 2016 -0400

    Add "#!/hint/bash" to the beginning of several files
    It is a method of notifying text-editors that a file is in Bash syntax
    without giving it a propper shebang (which would be confusing, as it
    would suggest that the file should be executable), as well as working
    across virtually all text-editors (unlike "-*- Mode: Bash -*-" or

commit 9672d6ec64ff5773df4b22bca9f2da44303dc03f
Author: Luke Shumaker <lukeshu at parabola.nu>
Date:   Wed Jun 18 21:04:02 2014 -0400

    Normalize to tab indent

commit 41333413f19e025d800e02c83511b85bee65ac60
Author: Luke Shumaker <lukeshu at parabola.nu>
Date:   Fri Jan 17 13:06:53 2014 -0500

    Export TMPDIR, and use mktemp -t instead of making it part of the template

commit 5c867ea3b857cba0993fc18e064c6f02f70ee099
Author: Eli Schwartz <eschwartz at archlinux.org>
Date:   Fri Mar 16 00:14:17 2018 -0400

    fixup! Update messages to make fuller use of printf formatters
    pkgs should be passed as a single argument


Summary of changes:
 config                                       |  4 +++-
 config.local.svn-community                   |  2 ++
 config.local.svn-packages                    |  2 ++
 cron-jobs/check_archlinux/parse_pkgbuilds.sh | 31 +++++++++-------------------
 cron-jobs/devlist-mailer                     |  6 +++---
 cron-jobs/ftpdir-cleanup                     |  6 +++---
 cron-jobs/sourceballs                        | 16 ++++++--------
 db-functions                                 | 30 +++++++++++----------------
 test/fixtures/pkg-simple-a/PKGBUILD          |  2 +-
 test/lib/common.bash                         |  6 ++++--
 testing2x                                    |  8 +++----
 11 files changed, 50 insertions(+), 63 deletions(-)

Official repo DB scripts

More information about the arch-projects mailing list