[arch-projects] [devtools] [PATCH] makechrootpkg: fix verifysource with pacman-git

[Eli Schwartz]

On 03/26/2018 06:19 PM, Luke Shumaker wrote:
>> -	chmod 1777 "$builddir"
>> +	chown "$makepkg_user:$makepkg_user" "$builddir"
> 
> $makepkg_user isn't nescessarily a valid group name.  Not all users
> have an identically named group, some people like to use 'users' as
> their primary group.
> 
> Looking at makepkg d8717a6a9666ec80c8645d190d6f9c7ab73084ac, I don't
> think the group of the directory has to match; just the user.
> However, if I'm mistaken and it it truly is nescessary to set the
> group, how about:
> 
> 	chown "$makepkg_user:$(id -gn "$makepkg_user")" "$builddir"

mmm, fair point. chown should actually be able to handle this itself via

chown "$makepkg_user:" "$builddir"

I guess it doesn't matter if the group is weird, except aesthetically.

-- 
Eli Schwartz
Bug Wrangler and Trusted User

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/arch-projects/attachments/20180326/1bcddece/attachment.asc>