[aur-dev] [PATCH] Fixed a couple more lingering JSON bugs

Loui louipc.ist at gmail.com
Wed Feb 20 15:26:06 EST 2008


On 2/20/08, Simo Leone <simo at archlinux.org> wrote:
> I'm pretty sure eliott wants to uber-optimize the json interface because
>  it's very possible that this code will get hit more frequently than
>  any other aur code.
>  Generally though, I don't really see anything wrong with string
>  concatenation, espcially if it enhances readability (which php tends to
>  lack sometimes imho).
>
>  Patch applied, without string concatenation
>
>  :) zoom zoom

Alrighty good stuff. That line that I did the string concatenation
actually had a valid fix though :P the space after AND at the end of
the string is required. Either that, or a space before "Name=" further
down in the code.




More information about the aur-dev mailing list