[aur-dev] [PATCH] Fixed a couple more lingering JSON bugs
simo at archlinux.org
Wed Feb 20 16:21:27 EST 2008
On Wed, Feb 20, 2008 at 03:26:06PM -0500, Loui wrote:
> On 2/20/08, Simo Leone <simo at archlinux.org> wrote:
> > I'm pretty sure eliott wants to uber-optimize the json interface because
> > it's very possible that this code will get hit more frequently than
> > any other aur code.
> > Generally though, I don't really see anything wrong with string
> > concatenation, espcially if it enhances readability (which php tends to
> > lack sometimes imho).
> > Patch applied, without string concatenation
> > :) zoom zoom
> Alrighty good stuff. That line that I did the string concatenation
> actually had a valid fix though :P the space after AND at the end of
> the string is required. Either that, or a space before "Name=" further
> down in the code.
hehehe, wow I missed that, I totally looked.
Fixed in testing though, and some git magic says you fixed it :)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 197 bytes
Desc: not available
More information about the aur-dev