[aur-dev] [PATCH] removed obsolete inline CSS in index.php

Angel Velásquez angvp at archlinux.com.ve
Sat Jun 7 11:06:51 EDT 2008


> +    print "<th colspan='2' class='boxSoftTitle'>";
>     print "<span class='f3'>".__("My Statistics")."</span>";
>     print "</th>";
>     print "</tr>";
> @@ -168,7 +168,7 @@ if (!empty($user)) {
>  print "<table class='boxSoft'>";
>
>  print "<tr>";
> -print "<th colspan='2' class='boxSoftTitle' style='text-align: right'>";
> +print "<th colspan='2' class='boxSoftTitle'>";
>  print "<span class='f3'>".__("Statistics")."</span>";
>  print "</th>";
>  print "</tr>";
> --
> 1.4.4.4
>
>
Oh hi Michael, good, but, i have to be annoying again (and sorry) but what
about with the double and simple quotes subject? i know that the file was
originally written bad, but try at least to don't copy and paste things
like:

print "</th>";
print "</tr>";

Remember, double quotes and simple quotes are important even if you think
that 'both works'. I tried to said you this in the other mail, and i thought
that you understood (i hope this time you will), thanks anyway, but please
try to clean the code (or maybe i say optimize it?) before submit a patch,
isn't the idea to patch and re-patch with bad-written-code.

Thanks!


-- 
Angel Velásquez
angvp @ irc.freenode.net
Linux Counter: #359909
Arch Linux Trusted User
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://archlinux.org/pipermail/aur-dev/attachments/20080607/6ea924c8/attachment.htm>


More information about the aur-dev mailing list