[aur-dev] AUR Coding recomendations IMPORTANT

Loui louipc.ist at gmail.com
Fri Jun 20 18:32:42 EDT 2008


On Fri, Jun 20, 2008 at 11:30:20PM +0200, chi at chimeric.de wrote:
> But, as you already said some source code files of the AUR are not really in
> shape in many ways when it comes to coding standards. The problem, as I see it
> for someone who likes to send a patch, is, that you usually address a specific
> "problem" with a patch. Although cleaning the code makes always sense, it
> should IMHO be separated into separate patch sets and not mixed with other
> patches in order to not blur the "real" purpose of a patch.

Yep that's the idea.

Ooh. I hadn't even thought of this:

  From: http://framework.zend.com/manual/en/coding-standard.html
> For files that contain only PHP code, the closing tag ("?>") is never
> permitted. It is not required by PHP. Not including it prevents trailing
> whitespace from being accidentally injected into the output. 

That's an easy fix that might prevent some issues from popping up.
The rss broke once because of a newline somewhere.





More information about the aur-dev mailing list