[aur-dev] [PATCH 3/5] Remove Dummy Package concept
archlinux at cryptocrack.de
Mon Apr 4 17:12:40 EDT 2011
On Wed, Mar 30, 2011 at 08:48:09PM -0500, Dan McGee wrote:
> Instead, we just store dependencies directly in the PackageDepends
> table. Since we don't use this info anywhere besides the package details
> page, there is little value in precalculating what is in the AUR vs.
> what is not.
> An upgrade path is provided via several SQL statements in the UPGRADING
> document. There should be no user-visible change from this, but the DB
> schema gets a bit more sane and we no longer have loads of junk packages
> in our tables that are never shown to the end user. This should also
> help the MySQL query planner in several cases as we no longer have to be
> careful to exclude dummy packages on every query.
> Signed-off-by: Dan McGee <dan at archlinux.org>
> UPGRADING | 12 ++++++++
> support/schema/aur-schema.sql | 5 +--
> support/scripts/newpackage-notify | 2 +-
> web/html/pkgsubmit.php | 17 ++--------
> web/html/rss.php | 1 -
> web/lib/aur.inc | 3 +-
> web/lib/aurjson.class.php | 4 +-
> web/lib/pkgfuncs.inc | 56 +++++++-----------------------------
> web/lib/stats.inc | 4 +-
> web/template/pkg_details.php | 21 ++++---------
> 10 files changed, 41 insertions(+), 84 deletions(-)
Just a short feedback: Those patches have already been in my working
tree for a few days now. I will double-check if there are no side
effects - especially with the dummy package removal - before merging and
pushing tho (just to be sure there's no unexpected breakage, e.g. this
one will remove all dummy package pages, like  - tho they're broken
anyways and have probably never been used by anyone).
More information about the aur-dev