[aur-dev] [PATCH v4 5/6] Add IDs to comments
Lukas Fleischer
lfleischer at archlinux.org
Fri Jul 10 17:15:26 UTC 2015
On Fri, 10 Jul 2015 at 18:47:35, Marcel Korpel wrote:
> Signed-off-by: Marcel Korpel <marcel.korpel at gmail.com>
> ---
> web/template/pkg_comments.php | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
The commit message is quite confusing. Comments already had IDs before
that change. Could you try to reword the message? Maybe something like
"Add anchors to comments"?
> diff --git a/web/template/pkg_comments.php b/web/template/pkg_comments.php
> index 91fdc26..e86db3b 100644
> --- a/web/template/pkg_comments.php
> +++ b/web/template/pkg_comments.php
> @@ -21,7 +21,7 @@ $count = pkgbase_comments_count($base_id, $include_deleted);
> $row['DelUserName'] = html_format_username($row['DelUserName']);
> $row['EditUserName'] = html_format_username($row['EditUserName']);
> ?>
> - <h4<?php if ($row['DelUsersID']): ?> class="comment-deleted"<?php endif; ?>>
> + <h4 id="comment-<?= $row['ID'] ?>"<?php if ($row['DelUsersID']): ?> class="comment-deleted"<?php endif; ?>>
> <?php if ($row['UserName']): ?>
> <?= __('%s commented', $row['UserName']) ?>
> <?php else: ?>
> --
> 2.4.5
More information about the aur-dev
mailing list