[aur-dev] [PATCH v4 5/6] Add IDs to comments

[Johannes Löthberg]

On 10/07, Lukas Fleischer wrote:
>On Fri, 10 Jul 2015 at 18:47:35, Marcel Korpel wrote:
>> Signed-off-by: Marcel Korpel <marcel.korpel at gmail.com>
>> ---
>>  web/template/pkg_comments.php | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>
>The commit message is quite confusing. Comments already had IDs before
>that change. Could you try to reword the message? Maybe something like
>"Add anchors to comments"?
>

That would be a bit misleading as well though, since it sounds like it's 
wrapped in <a> tags. Maybe something like `Add IDs to comment heading 
tags`?
>> diff --git a/web/template/pkg_comments.php b/web/template/pkg_comments.php
>> index 91fdc26..e86db3b 100644
>> --- a/web/template/pkg_comments.php
>> +++ b/web/template/pkg_comments.php
>> @@ -21,7 +21,7 @@ $count = pkgbase_comments_count($base_id, $include_deleted);
>>                 $row['DelUserName'] = html_format_username($row['DelUserName']);
>>                 $row['EditUserName'] = html_format_username($row['EditUserName']);
>>                 ?>
>> -               <h4<?php if ($row['DelUsersID']): ?> class="comment-deleted"<?php endif; ?>>
>> +               <h4 id="comment-<?= $row['ID'] ?>"<?php if ($row['DelUsersID']): ?> class="comment-deleted"<?php endif; ?>>
>>                         <?php if ($row['UserName']): ?>
>>                         <?= __('%s commented', $row['UserName']) ?>
>>                         <?php else: ?>
>> --
>> 2.4.5

-- 
Sincerely,
  Johannes Löthberg
  PGP Key ID: 0x50FB9B273A9D0BB5
  https://theos.kyriasis.com/~kyrias/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 1495 bytes
Desc: not available
URL: <https://lists.archlinux.org/pipermail/aur-dev/attachments/20150710/0ba22079/attachment.asc>