[aur-dev] [PATCH] Limit comment height to 15 lines

Lukas Fleischer lfleischer at archlinux.org
Sun Mar 13 08:23:57 UTC 2016


On Sat, 12 Mar 2016 at 15:50:03, Eric Engestrom wrote:
> Signed-off-by: Eric Engestrom <eric at engestrom.ch>
> ---
>  web/html/css/aurweb.css | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/web/html/css/aurweb.css b/web/html/css/aurweb.css
> index f5e1037..f777ab8 100644
> --- a/web/html/css/aurweb.css
> +++ b/web/html/css/aurweb.css
> @@ -148,3 +148,8 @@ label.confirmation,
>         color: red;
>         font-weight: bold;
>  }
> +
> +#news div p {
> +       max-height: 15em;
> +       overflow: auto;
> +}

The idea sounds good, however I am not 100% sure about the
implementation. We already do have JavaScript code for collapsing long
dependency lists (which we borrowed from archweb). Do we want to use the
same code for comments for consistency? It also makes it a bit easier to
read long comments since, once you decided that you want to expand it,
you no longer need to scroll. On the other hand, I like that this
alternative implementation does not require JavaScript...

I put your patch on the pu branch for now but I would like to hear some
more opinions. Thanks!

> -- 
> 2.7.2


More information about the aur-dev mailing list