[aur-dev] [PATCH] Limit comment height to 15 lines

[Gordian Edenhofer]

On Mar 13, 2016 9:24 AM, "Lukas Fleischer" <lfleischer at archlinux.org> wrote:
>
> On Sat, 12 Mar 2016 at 15:50:03, Eric Engestrom wrote:
> > Signed-off-by: Eric Engestrom <eric at engestrom.ch>
> > ---
> >  web/html/css/aurweb.css | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/web/html/css/aurweb.css b/web/html/css/aurweb.css
> > index f5e1037..f777ab8 100644
> > --- a/web/html/css/aurweb.css
> > +++ b/web/html/css/aurweb.css
> > @@ -148,3 +148,8 @@ label.confirmation,
> >         color: red;
> >         font-weight: bold;
> >  }
> > +
> > +#news div p {
> > +       max-height: 15em;
> > +       overflow: auto;
> > +}
>
> The idea sounds good, however I am not 100% sure about the
> implementation. We already do have JavaScript code for collapsing long
> dependency lists (which we borrowed from archweb). Do we want to use the
> same code for comments for consistency? It also makes it a bit easier to
> read long comments since, once you decided that you want to expand it,
> you no longer need to scroll. On the other hand, I like that this
> alternative implementation does not require JavaScript...
>
> I put your patch on the pu branch for now but I would like to hear some
> more opinions. Thanks!
>

I am in favor of using JavaScript for the reasons Lukas already mentioned.
Once you are willing to read the whole comment it gets annoying to scroll
anymore. Furthermore JavaScript is used either way.

Best regards,
Gordian